[countersyncd]: Add communication statistics recording and utilities#4151
Merged
prsunny merged 3 commits intosonic-net:masterfrom Jan 24, 2026
Merged
[countersyncd]: Add communication statistics recording and utilities#4151prsunny merged 3 commits intosonic-net:masterfrom
prsunny merged 3 commits intosonic-net:masterfrom
Conversation
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Pterosaur
force-pushed
the
countersyncd_add_debug
branch
from
9b268e0 to
9ffb842
Compare
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Signed-off-by: Ze Gan <ganze718@gmail.com>
Pterosaur
force-pushed
the
countersyncd_add_debug
branch
from
9ffb842 to
13a10a8
Compare
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
There was a problem hiding this comment.
Pull request overview
This PR adds communication statistics recording and debugging utilities to countersyncd for analyzing online issues and performance. The changes introduce a new utilities module with functions for formatting hex dumps and tracking inter-actor channel statistics.
Changes:
- Added utilities module with hex formatting and channel statistics tracking
- Instrumented all actor message receive points to record queue lengths
- Added debug logging for raw netlink message payloads
Reviewed changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| crates/countersyncd/src/utilities/mod.rs | New module providing hex formatting utility and communication statistics tracking with periodic logging |
| crates/countersyncd/src/main.rs | Added utilities module and initialized channel capacity tracking for all communication channels |
| crates/countersyncd/src/lib.rs | Exported the new utilities module |
| crates/countersyncd/src/actor/stats_reporter.rs | Added channel statistics recording for IpfixToStatsReporter channel |
| crates/countersyncd/src/actor/otel.rs | Added channel statistics recording for IpfixToOtel channel and cleaned up trailing whitespace |
| crates/countersyncd/src/actor/ipfix.rs | Added channel statistics recording for SwssToIpfixTemplates and DataNetlinkToIpfixRecords channels, cleaned up whitespace |
| crates/countersyncd/src/actor/data_netlink.rs | Added channel statistics recording for ControlNetlinkToDataNetlink channel and hex dump logging for netlink messages, cleaned up whitespace |
| crates/countersyncd/src/actor/counter_db.rs | Added channel statistics recording for IpfixToCounterDb channel |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
r12f
reviewed
Jan 23, 2026
| impl ChannelLabel { | ||
| fn as_str(self) -> &'static str { | ||
| match self { | ||
| ChannelLabel::ControlNetlinkToDataNetlink => "control_netlink->data_netlink_cmd", |
Signed-off-by: Ze Gan <ganze718@gmail.com>
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
prsunny
approved these changes
Jan 24, 2026
Pterosaur
added
Request for msft-202412 Branch
and removed
Request for msft-202412 Branch
Cherry Pick Conflict_msft-202412
labels
Collaborator
|
Cherry-pick PR to msft-202412: Azure/sonic-swss.msft#199 |
Collaborator
|
@Pterosaur cherry pick PR didn't pass PR checker. Please check!!! |
1 similar comment
Collaborator
|
@Pterosaur cherry pick PR didn't pass PR checker. Please check!!! |
r12f
added
Included in msft-202412 Branch
and removed
Created PR to msft-202412 Branch
labels
Contributor
|
@Pterosaur @liat-grozovik please manually create 202511 as there are cherry pick conflicts. |
Contributor
Author
|
Retrigger msbuild bot |
Collaborator
|
Cherry-pick PR to 202511: #4222 |
mssonicbld
added
Included in 202511 Branch
and removed
Created PR to 202511 Branch
labels
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What I did
Add more debug and statistics logs for countersyncd
Why I did it
Used for analyzing online issues and performance.
How I verified it
Locally check
Details if related